[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] qemu: Rewrite LOOKUP_PTYS macro into a function



On Mon, Apr 04, 2011 at 13:49:04 -0600, Eric Blake wrote:
> On 04/04/2011 07:46 AM, Jiri Denemark wrote:
> > The macro is huge and gives us nothing but headache when maintaining it.
> > ---
> > The reason for this patch is not that I'm going to modify anything in
> > the code. It's that I was working in the area and noticed this huge
> > macro.
> > 
> >  src/qemu/qemu_process.c |  102 ++++++++++++++++++++++++++++-------------------
> >  1 files changed, 61 insertions(+), 41 deletions(-)
> 
> The diffstat hides the fact that this really is a code cleanup.
> 
> ACK.

Thanks, pushed.

Jirka


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]