[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] qemu: Always reserves slot 0x02 for primary VGA.



On Wed, Apr 06, 2011 at 02:24:42PM +0800, Osier Yang wrote:
> 于 2011年04月05日 23:19, Eric Blake 写道:
> >On 04/05/2011 07:49 AM, Osier Yang wrote:
> >>To address https://bugzilla.redhat.com/show_bug.cgi?id=692355
> >>
> >>This fix is to reserve slot 0x02 for primary VGA even if there
> >>is no "video" specified in domain XML to avoid the problem.
> >>---
> >>  src/qemu/qemu_command.c |   13 ++++++++++---
> >>  1 files changed, 10 insertions(+), 3 deletions(-)
> >
> >ACK.  I think that this is the correct patch, given the earlier comments
> >on the same topic in
> >https://www.redhat.com/archives/libvir-list/2011-March/msg01296.html
> >
> 
> Thanks, applied, for the virtio-blk problem, will be a seperate patch.

This patch has broken quite a few cases in the qemuxml2argvtest
Since many data files didn't include a VGA card, many PCI slots
need changing in them. Can you post a fix for it...

Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]