[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 2/2] doc: Update doc for restoring in virsh manual



On 04/06/2011 12:17 AM, Osier Yang wrote:
> ---
>  tools/virsh.pod |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
> 
> diff --git a/tools/virsh.pod b/tools/virsh.pod
> index f4bd294..507686c 100644
> --- a/tools/virsh.pod
> +++ b/tools/virsh.pod
> @@ -546,7 +546,8 @@ I<on_reboot> parameter in the domain's XML definition.
> 
>  =item B<restore> I<state-file>
> 
> -Restores a domain from an B<virsh save> state file.  See I<save> for more info.
> +Restores a domain from an B<virsh save> state file. If restoring
> +succeeded, the state file will be removed. See I<save> for more info.

NACK.  Based on subsequent discussion on v2, this should instead be
something like:

To avoid corrupting file system contents within the guest, you should
not reuse a saved state file after a successful restore unless you have
also taken steps to revert the guest's storage volumes back to the
contents they had when the domain state file was created.

-- 
Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]