[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v2 0/4] RFC: vcpupin: configure inactive domains' CPU affinity setting



On Fri, Apr 08, 2011 at 02:14:07PM +0900, Taku Izumi wrote:
> Hi all,
> 
> This patchset enables us to configure inactive domains' CPU affinity setting.
> 
> The basic technique is the same as that of "virsh setmem" command. 
>  => http://www.redhat.com/archives/libvir-list/2011-March/msg00013.html
>  
> v1 -> v2:
>  - recreate based on 0.9.0
>  - add "CURRENT" mode 
> 
>  *[PATCH 1/4] vcpupin: inroduce a new libvir API (virDomainPinVcpuFlags)
>  *[PATCH 2/4] vcpupin: implement the code to address the new API in the qemu driver
>  *[PATCH 3/4] vcpupin: implement the remote protocol to address the new API
>  *[PATCH 4/4] vcpupin: add the new options to "virsh vcpupin" command
> 
> Best regards,
> Taku Izumi

Two suggestions:

- when vcpupin an inactive domain, it gives an error message like this:

  error: Requested operation is not valid: cannot pin vcpus on an inactive domain
  
  After applying this series, this is not true anymore. I think a
  message like this is more helpful:

  Failed to pin vcpus on inactive domain, please check the --config option.

- While it can vcpupin an inactive domain, it seems reasonable to be
  able to view vcpuinfo of inactive domain, so would a patch to
  vcpuinfo command be included?


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]