[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] do not build libvirt_iohelper when building without libvirtd



On Fri, Apr 08, 2011 at 11:26:47AM +0800, Wen Congyang wrote:
> The libexec program libvirt_iohelper is only for libvirtd. If we build rpm
> without libvirtd, we will receive the following messages:
> 
> Checking for unpackaged file(s): /usr/lib/rpm/check-files /home/wency/rpmbuild/BUILDROOT/libvirt-0.9.0-1.el6.x86_64
> error: Installed (but unpackaged) file(s) found:
>    /usr/libexec/libvirt_iohelper
> 
> ---
>  src/Makefile.am |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/src/Makefile.am b/src/Makefile.am
> index 3649106..dce866e 100644
> --- a/src/Makefile.am
> +++ b/src/Makefile.am
> @@ -1183,6 +1183,7 @@ EXTRA_DIST += $(LIBVIRT_QEMU_SYMBOL_FILE)
>  
>  libexec_PROGRAMS =
>  
> +if WITH_LIBVIRTD
>  libexec_PROGRAMS += libvirt_iohelper
>  libvirt_iohelper_SOURCES = $(UTIL_IO_HELPER_SOURCES)
>  libvirt_iohelper_LDFLAGS = $(WARN_LDFLAGS) $(AM_LDFLAGS)
> @@ -1191,6 +1192,7 @@ libvirt_iohelper_LDADD =		\
>  		../gnulib/lib/libgnu.la
>  
>  libvirt_iohelper_CFLAGS = $(AM_CFLAGS)
> +endif
>  
>  if WITH_STORAGE_DISK
>  if WITH_LIBVIRTD

  sounds right, ACK

Daniel

-- 
Daniel Veillard      | libxml Gnome XML XSLT toolkit  http://xmlsoft.org/
daniel veillard com  | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library  http://libvirt.org/


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]