[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 3/3] setmaxmem: add the new options to "virsh setmaxmem" command



On 04/07/2011 11:08 PM, Taku Izumi wrote:
> 
> This patch adds the new options (--live, --config, and --current) to "virsh setmaxmem"
> command. The behavior of above options is the same as that of "virsh setmem".
> When the --config option is specified, a modofication is effective for the

s/modofication/modification/

> persistent domain, while the --live option is specified, a modification is effective
> for an active domain. The --current option is specified, it affects a current domain.

Long lines - 80 columns is nice, and for commit messages, I tend to be
even more conservative at 70 columns (since git log indents the text).

> 
> +
> +    if (current) {
> +        if(live || config) {

s/if(/if (/

ACK with that nit fixed, and pushed.

-- 
Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]