[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] util: Fix crash when removing entries during hash iteration



On Tue, Apr 12, 2011 at 11:06:17 -0600, Eric Blake wrote:
> On 04/12/2011 10:54 AM, Jiri Denemark wrote:
> > Commit 9677cd33eea4c65d78ba463b46b8b45ed2da1709 made it possible to
> > remove current entry when iterating through all hash entries. However,
> > it didn't properly handle a special case of removing first entry
> > assigned to a given key which contains several entries in its collision
> > list.
> > ---
> > This is an alternate less invasive fix to "util: Simplify hash implementation".
> > I prefer the more invasive fix for upstream but I'm sending this alternative
> > here for completeness.
> 
> For backporting purposes, would it make sense to apply this patch first,
> then apply the other one which undoes this patch as part of its
> simplifications?  Then, anyone trying to pick and choose patches to
> backport can feel justified going with the smaller patch in isolation.

That sounds like a good idea. I'll send a v2 for the simplification patch
soon.

> As for this patch itself, ACK, but whether to apply it depends on the
> answer to the bigger question above.

Thanks and I pushed it.

Jirka


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]