[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] virsh: Add --name and --description options to snapshot-create



On Mon, Apr 11, 2011 at 11:36:00AM -0600, Eric Blake wrote:
> On 04/10/2011 05:31 AM, Matthias Bolte wrote:
> > This options are shortcuts to set name and description of a snapshot.
> > 
> > Suggested by Elias Probst
> > ---
> > 
> > I'm not sure if this is be best approach. In case of the vol-* commands there
> > is vol-create that takes and XML file and vol-create-as that takes a set of
> > arguments.
> > 
> > So, should there actually be a snapshot-create-as to takes --name and
> > --description options?
> 
> For consistency, I would argue that we don't have any other commands
> that modify direct xml input, and so we shouldn't be starting that now.
>  I agree that a snapshot-create-as that takes options (and builds xml
> under the hood) would match with existing virsh paradigms better than
> making the existing snapshot-create command modify input xml on the fly.
>  In other words, I'm afraid that your concern was unfortunately valid,
> and that we should NACK this patch in favor of one that adds a new
> command instead.

  Agreed !

Daniel

-- 
Daniel Veillard      | libxml Gnome XML XSLT toolkit  http://xmlsoft.org/
daniel veillard com  | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library  http://libvirt.org/


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]