[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] Introduce virDomainChrDefNew()



On 04/13/2011 09:14 AM, Michal Novotny wrote:
> Hi,
> this is the commit to introduce the function to create new character
> device definition for the domain as advices by Cole Robinson

s/advices/advised/

> <crobinso redhat com>.
> 
> The function is used on the relevant places and the make, make check
> and make syntax-check all passed.
> 
> Michal
> 
> Signed-off-by: Michal Novotny <minovotn redhat com>
> Signed-off-by: Michal Novotny <mignov gmail com>

Technically, a sign-off line is for a person, not an email address, so
having two sign-offs looks weird.  Given that your redhat address is the
one listed in AUTHORS, as well as the one you sent this message with,
that should be sufficient.  But if you ever do want to use multiple
addresses, we maintain a .mailmap file which lets you commit under more
than one alias while still mapping back to a single AUTHORS line.

Cole's review just came in while I was typing this, so I'll wait for a v2.

> +++ b/src/libvirt_private.syms
> @@ -333,6 +333,7 @@ virDomainWatchdogActionTypeFromString;
>  virDomainWatchdogActionTypeToString;
>  virDomainWatchdogModelTypeFromString;
>  virDomainWatchdogModelTypeToString;
> +virDomainChrDefNew;

In addition to Cole's finding, please keep this file sorted (chunks by
header name, then within a chunk sort by function name).

-- 
Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]