[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] Introduce virDomainChrDefNew()

On 04/13/2011 05:42 PM, Eric Blake wrote:
> On 04/13/2011 09:14 AM, Michal Novotny wrote:
>> Hi,
>> this is the commit to introduce the function to create new character
>> device definition for the domain as advices by Cole Robinson
> s/advices/advised/

Thanks for noticing this typo.

>> <crobinso redhat com>.
>> The function is used on the relevant places and the make, make check
>> and make syntax-check all passed.
>> Michal
>> Signed-off-by: Michal Novotny <minovotn redhat com>
>> Signed-off-by: Michal Novotny <mignov gmail com>
> Technically, a sign-off line is for a person, not an email address, so
> having two sign-offs looks weird.  Given that your redhat address is the
> one listed in AUTHORS, as well as the one you sent this message with,
> that should be sufficient.  But if you ever do want to use multiple
> addresses, we maintain a .mailmap file which lets you commit under more
> than one alias while still mapping back to a single AUTHORS line.

The second sign-off by clause has been added automatically by git
format-patch and I was having incorrect setup of the git config so it
should be fine by now. I don't want to use multiple e-mail addresses for
libvirt and I want to use redhat address only so this was a
misconfiguration of my git.

> Cole's review just came in while I was typing this, so I'll wait for a v2.
>> +++ b/src/libvirt_private.syms
>> @@ -333,6 +333,7 @@ virDomainWatchdogActionTypeFromString;
>>  virDomainWatchdogActionTypeToString;
>>  virDomainWatchdogModelTypeFromString;
>>  virDomainWatchdogModelTypeToString;
>> +virDomainChrDefNew;
> In addition to Cole's finding, please keep this file sorted (chunks by
> header name, then within a chunk sort by function name).

I see what you mean. I will.


Michal Novotny <minovotn redhat com>, RHCE
Virtualization Team (xen userspace), Red Hat

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]