[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [libvirt-php 2/2] Fix possible uninitialized variable



On 04/14/2011 10:50 AM, Lyre wrote:
> ---
>  src/libvirt-php.c |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/src/libvirt-php.c b/src/libvirt-php.c
> index 020da4e..d436e1c 100644
> --- a/src/libvirt-php.c
> +++ b/src/libvirt-php.c
> @@ -1204,7 +1204,8 @@ char *get_string_from_xpath(char *xml, char *xpath, zval **val, int *retVal)
>  	xmlXPathObjectPtr result;
>  	xmlNodeSetPtr nodeset;
>  	int ret = 0, i;
> -	char *value, key[8] = { 0 };
> +	char *value = NULL; 
> +	char key[8] = { 0 };
>  
>  	if ((xpath == NULL) || (xml == NULL))
>  	{
Good change. Thanks and pushed.

Michal

-- 
Michal Novotny <minovotn redhat com>, RHCE
Virtualization Team (xen userspace), Red Hat


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]