[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] esx: Cleanup VI generator code



2011/4/12 Daniel Veillard <veillard redhat com>:
> On Sun, Apr 10, 2011 at 01:26:47PM +0200, Matthias Bolte wrote:
>> ---
>>  src/esx/esx_vi_generator.py |  177 +++++++++++++++++--------------------------
>>  1 files changed, 71 insertions(+), 106 deletions(-)
>>
>> diff --git a/src/esx/esx_vi_generator.py b/src/esx/esx_vi_generator.py
>> index 3d068f3..622a34a 100755
>> --- a/src/esx/esx_vi_generator.py
>> +++ b/src/esx/esx_vi_generator.py
>> @@ -41,6 +41,11 @@ valid_occurrences = [OCCURRENCE__REQUIRED_ITEM,
>>
>>
>>
>> +def aligned(left, right):
>> +    while len(left) < 59:
>> +        left += " "
>> +
>> +    return left + right
>
>  crude but that works :-) for the generator it's fine,
>
>    overall I'm not sure many understand that code beside you,

Well, probably. Actually I thing the code of the generator isn't that
complex, but it missing documentation how it's working in general,
that's true.

It's somewhere on my todo list to improve the overall documentation of
the ESX driver codebase.

>      ACK
>
> Daniel

Thanks, pushed.

Matthias


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]