[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] network: truncate bridges' dummy tap device names to IFNAMSIZ (15) chars



On 04/14/2011 12:52 AM, Laine Stump wrote:
>> Should we also minimize the truncation by adding just "-n" instead of
>> "-nic", so that there are fewer user strings being butchered?  Or would
>> that cause problems for existing users that already have bridge-nic and
>> would now also have bridge-n?
> 

> So, is this minor artifact worth getting the extra two characters? I'll
> let the patch sit until midday, and if someone comes out in support of
> changing it, I'll reduce the suffix to "-n" and push, otherwise I'll
> push as-is.

I can live with the patch as-is, if no one else speaks for the two extra
characters.

-- 
Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]