[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 0/6] Add support for injecting NMI to guest



On 04/12/2011 10:56 PM, Lai Jiangshan wrote:
> 
> 
> This patch series implements a feature of injecting NMI to guest,
> which is accessible via new virDomainInjectNMI API and
> 'inject-nmi' command in virsh.
> 
> Lai Jiangshan (6):
>   inject-nmi: Defining the public API
>   inject-nmi: Defining the internal API
>   inject-nmi: Implementing the public API
>   inject-nmi: Implementing the remote protocol
>   inject-nmi: Expose the new API in virsh
>   qemu,inject-nmi: Implement the driver methods

This is v2 of:
https://www.redhat.com/archives/libvir-list/2011-April/msg00036.html
If you use 'git format-patch --subject-prefix=PATCHv2' (or send-email
instead of format-patch), it makes it easier to see that this is a resend.

Thanks for splitting it up; that helps review.

My quick glance at 1-5 didn't turn up any glaring problems, but I'm
still not sure we've got the semantics right.  I'll reply to patch 6,
and think we'll need another spin to get the API right.

-- 
Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]