[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCHv2 7/9] phyp: use consistent return string handling



2011/4/14 Eric Blake <eblake redhat com>:
> Use the name 'ret' for all phypExec results, to make it easier
> to wrap phypExec.  Don't allow a possibly NULL ret through printf.
>
> * src/phyp/phyp_driver.c (phypBuildVolume, phypDestroyStoragePool)
> (phypBuildStoragePool, phypBuildLpar): Avoid NULL dereference.
> (phypInterfaceDestroy): Avoid redundant free.
> (phypVolumeLookupByPath, phypVolumeGetPath): Use consistent
> naming.
> ---
>  src/phyp/phyp_driver.c |   37 +++++++++++++++++--------------------
>  1 files changed, 17 insertions(+), 20 deletions(-)
>

ACK.

Matthias


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]