[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v2] Remove virConnectPtr from virRaiseErrorFull



On 04/16/2011 02:32 AM, Matthias Bolte wrote:
> And from all related macros and functions.
> ---
> 
> I posted v1 a year ago :)
> 
> https://www.redhat.com/archives/libvir-list/2010-April/msg00164.html

And I even ack'd it, but a lot has changed in the meantime.

> +++ b/src/conf/cpu_conf.c
> @@ -32,7 +32,7 @@
>  #define VIR_FROM_THIS VIR_FROM_CPU
>  
>  #define virCPUReportError(code, ...)                              \
> -    virReportErrorHelper(NULL, VIR_FROM_CPU, code, __FILE__,      \
> +    virReportErrorHelper(VIR_FROM_CPU, code, __FILE__,            \
>                           __FUNCTION__, __LINE__, __VA_ARGS__)

The argument was truly unused, so this is a nice cleanup.

ACK.

-- 
Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]