[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] Update and sort msg_gen_function list and mark unmarked messages



On 04/17/2011 12:30 AM, Matthias Bolte wrote:
> Inspired by Eric Blake

Good to know I'm setting expectations :)

> ---
>  cfg.mk                       |   45 ++++++++++++++++++++++++++++++++++-------
>  src/interface/netcf_driver.c |   43 ++++++++++++++++++---------------------
>  src/nodeinfo.c               |    2 +-
>  src/phyp/phyp_driver.c       |   18 ++++++++--------
>  src/util/stats_linux.c       |    2 +-
>  5 files changed, 68 insertions(+), 42 deletions(-)
> 
> @@ -182,8 +183,7 @@ static int interfaceNumOfInterfaces(virConnectPtr conn)
>          const char *errmsg, *details;
>          int errcode = ncf_error(driver->netcf, &errmsg, &details);
>          interfaceReportError(netcf_to_vir_err(errcode),
> -                             "%s (netcf: %s - %s)",
> -                             _("failed to get number of interfaces on host"),
> +                             _("failed to get number of interfaces on host (netcf: %s - %s)"),

This rewrite looks sane.  I think that it would have also worked to use:

_("%s (netcf: %s - %s"),
_("failed to get number of interfaces on host"),

but since I don't know whether translators would like that any better, I
don't think you should bother changing it.

ACK.

-- 
Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]