[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] build: Fix problem of building Python bindings



于 2011年04月27日 14:59, Daniel Veillard 写道:
On Wed, Apr 27, 2011 at 11:46:33AM +0800, Osier Yang wrote:
If one specify "--with-python=yes" but no python-devel package
is installed, we ignore it with just a notice message, which
doesn't give clear guide to user.
---
  configure.ac |    6 ++----
  1 files changed, 2 insertions(+), 4 deletions(-)

diff --git a/configure.ac b/configure.ac
index 190bf40..758c893 100644
--- a/configure.ac
+++ b/configure.ac
@@ -1917,15 +1917,13 @@ if test "$with_python" != "no" ; then
                          then
                              PYTHON_INCLUDES=-I/usr/include/python$PYTHON_VERSION
                          else
-                            AC_MSG_NOTICE([Could not find python$PYTHON_VERSION/Python.h, disabling bindings])
-                            with_python=no
+                            AC_MSG_ERROR([You must install python-devel to build Python bindings])
                          fi
                      fi
                  fi
              fi
          else
-            AC_MSG_NOTICE([Could not find python interpreter, disabling bindings])
-            with_python=no
+            AC_MSG_ERROR([You must install python to build Python bindings])
          fi
      else
          AC_MSG_NOTICE([Could not find python in $with_python, disabling bindings])

   Hum ... the message may be a bit less "generaic" but probably more
   useful, okay

   ACK,

Daniel


Thanks, applied

Osier


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]