[libvirt] [PATCH] Xen: Do not generate net ifname if domain is inactive

Jim Fehlig jfehlig at novell.com
Thu Apr 28 20:56:01 UTC 2011


Eric Blake wrote:
> On 04/28/2011 02:45 PM, Jim Fehlig wrote:
>   
>>> Rather than using snprintf and strdup, can't we just use:
>>>
>>> if (virAsprintf(&net->ifname, "vif%d.%d", def->id, vif_index) < 0)
>>>     goto no_memory;
>>>   
>>>       
>> Yes, good point.  Here is a V2.
>>     
>
> ACK.
>   

Thanks, pushed now.

Regards,
Jim



More information about the libvir-list mailing list