[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCHv12 3/3] libvirt/qemu - support persistent update of disks



On 04/21/2011 09:10 PM, KAMEZAWA Hiroyuki wrote:
> Support update of disks by MODIFY_CONFIG
> 
> This patch includes changes for qemu's disk to support
> virDomainUpdateDeviceFlags() with VIR_DOMAIN_DEVICE_MODIFY_CONFIG.
> 
> This patch adds support for CDROM/foppy disk types.
> 
> Signed-off-by: KAMEZAWA Hiroyuki <kamezawa hiroyu jp fujitsu com>
> 
> Changelog: v11->v12
>   - rebased.(qemud->qemu)
> 
> * src/qemu/qemu_driver.c
> (qemuDomainUpdateDeviceConfig): support cdrom/floppy.
> ---
>  src/qemu/qemu_driver.c |   40 +++++++++++++++++++++++++++++++++++++++-
>  1 files changed, 39 insertions(+), 1 deletions(-)

ACK.  Technically, this is a feature addition and after the freeze
created by the 0.9.1 release candidate 1, but my review of the earlier
patches in this series was interleaved with DV's announcement of the rc1
creation.  So I'd rather get this in now even if it is just a feature
addition, to round out the series; and maybe we'll have an rc2 build
with it in to make sure it didn't royally screw anything up.

Thanks again for your persistence (sorry for the pun :) in getting this
feature added.  While all of the functionality was already present via
raw XML editing, this sure makes it easier to do via virsh.

-- 
Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]