[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] virsh: avoid compiler warning on mingw



On 04/28/2011 07:02 PM, Daniel Veillard wrote:
> On Thu, Apr 28, 2011 at 03:11:23PM -0600, Eric Blake wrote:
>> We don't use gnulib's sanitizations for vfprintf, but vshDebug
>> was used with %zu, which means that it would fail on mingw.
>> Thank goodness the compiler indirectly caught this for us :)
>>
>> virsh.c: In function 'vshDebug':
>> virsh.c:12105:5: warning: function might be possible candidate for
>> 'ms_printf' format attribute [-Wmissing-format-attribute]
>>
>> since mingw <stdio.h> hasn't yet added gcc attributes to vfprintf.
>>
>> * tools/virsh.c (vshDebug): Avoid vfprintf.
>> (vshPrintExtra): Use lighter-weight fputs.
>> Reported by Matthias Bolte.
> 
>   ACK,

Thanks; pushed.

-- 
Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]