[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] nwfilter: Fix memory leak in the ebtables subdriver



On 04/30/2011 05:12 AM, Matthias Bolte wrote:
> Call shutdown functions for all subcompontents in nwfilterDriverShutdown.

s/subcompontents/subcomponents/ (twice)

> +++ b/src/conf/nwfilter_conf.c
> @@ -125,6 +125,7 @@ struct int_map {
>   * only one filter update allowed
>   */
>  static virMutex updateMutex;
> +static bool initialized = false;

You could omit '= false' and still get the same results, since static
storage is guaranteed to be zero-initialized, but that's just style and
does not have to be changed.

ACK.

-- 
Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]