[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCHv3] qemu: fix crash when mixing sync and async monitor jobs



On 07/31/2011 09:00 PM, Wen Congyang wrote:
> At 07/30/2011 05:32 AM, Eric Blake Write:
>> Currently, we attempt to run sync job and async job at the same time. It
>> means that the monitor commands for two jobs can be run in any order.
>>
>>
>> v3: incorporate Wen's feedback - in particular, virProcessStartCPUs
>> now checks for return type, restarting libvirt does not use an
>> async job, and I didn't hit the deadlock in the same scenarios as
>> I tested under v2.
> 
> I diff this patch with v2, and all comments have been addressed.
> And the deadlock also has been fixed.
> 
>> I still need to do migration testing before I'm convinced that this
>> is right, but it's doing a lot better.
> 
> If migration testing pass, ACK.

Yes, I was able to migrate guests with this patch and with virt-manager
running on both source and destination, without seeing the crash after
multiple attempts.

I've gone ahead and pushed this; any further issues we identify will
have to be separate patches.

-- 
Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]