[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] freebsd: Add gnulib environ module for the commandtest



2011/8/2 Daniel P. Berrange <berrange redhat com>:
> On Thu, Jul 28, 2011 at 07:56:18AM -0600, Eric Blake wrote:
>> On 07/28/2011 07:52 AM, Matthias Bolte wrote:
>> >At least all tests compile on FreeBSD again. But most of the SSH cases
>> >in virnetmessagetest are failing and I don't understand why yet.
>>
>> Could it be a PATH vs. exec() issue, where BSD ends up doing a
>> slightly different PATH search and not executing the dummy 'ssh'
>> script from our test directory?  Does a ktrace (or truss or strace
>> or however it's spelled) shed any light?
>
> NB, if you run  ./virnetsockettest it won't work. You have to run
>
>   PATH=`pwd`:$PATH ./virnetsockettest

That's true and this way is works on FreeBSD too.

> Or
>
>   make check TESTS=virnetsockettest
>
> to ensure the $PATH is set to find the local fake ssh

This way it doesn't because the makefile extends the path in a
non-portable way. Eric fixed this

http://libvirt.org/git/?p=libvirt.git;a=commit;h=343ab98229a60126ec75087dd425207392b77754

-- 
Matthias Bolte
http://photron.blogspot.com


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]