[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v3] daemon: Unlink unix socket paths on shutdown

On 08/03/2011 07:37 AM, Osier Yang wrote:
This patch introduces a internal RPC API "virNetServerClose", which
is standalone with "virNetServerFree".  it closes all the socket fds,
and unlinks the unix socket paths, regardless of whether the socket
is still referenced or not.

This is to address regression bug:
  daemon/libvirtd.c             |    1 +
  src/rpc/virnetserver.c        |   16 ++++++++++++++++
  src/rpc/virnetserver.h        |    1 +
  src/rpc/virnetserverservice.c |   12 ++++++++++++
  src/rpc/virnetserverservice.h |    2 ++
  src/rpc/virnetsocket.c        |   22 ++++++++++++++++++++++
  src/rpc/virnetsocket.h        |    1 +
  7 files changed, 55 insertions(+), 0 deletions(-)

You've addressed all my comments, but you're probably best waiting for an ack from danpb.

Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]