[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 3/3] qemu: avoid dead store in doPeer2PeerMigrate3

On 08/03/2011 11:30 PM, Alex Jia wrote:
Value stored to 'ret' is never read. If Confirm3 returns -1, there's nothing
more we can do, here should remove this dead assignment.

* src/qemu/qemu_migration.c: kill dead assignment.

Signed-off-by: Alex Jia<ajia redhat com>
  src/qemu/qemu_migration.c |    6 +++---
  1 files changed, 3 insertions(+), 3 deletions(-)

I'm thinking NACK as written. We should probably emit a log message if confirm failed, at which point, ret would be used in the conditional deciding whether to do a log message. Furthermore, libvirt.c virDomainMigrateVersion3 has the same bug with a dead assignment to ret; we should solve it in the same way for both implementations.

Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]