[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] qemu: Fix -chardev udp if parameters are omitted



On 08/10/2011 01:15 AM, Daniel Veillard wrote:
On Tue, Mar 22, 2011 at 04:08:10PM -0600, Eric Blake wrote:
On 03/22/2011 02:36 PM, Cole Robinson wrote:
The following XML:

     <serial type='udp'>
       <source mode='connect' service='9999'/>
     </serial>

is accepted by domain_conf.c but maps to the qemu command line:

-chardev udp,host=127.0.0.1,port=2222,localaddr=(null),localport=(null)


   The patch has been rebased, I use temp variables instead as I find
this more readable (but slightly more verbose I admit) and keeps the
arguments order. There is a small tweak to the original patch on
qemuParseCommandLineChr bindService to avoid taking 0 as anything but
the default.

ACK.

--
Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]