[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] nwfilter: tolerate disappearing interfaces while instantiating filter



On 08/10/2011 11:14 AM, Eric Blake wrote:
On 08/10/2011 04:34 AM, Stefan Berger wrote:
When instantiating a filter, a VM may disappear and remove its tap
interfaces. Tolerate this case and don't report an error.

Signed-off-by: Stefan Berger <stefanb linux vnet ibm com>


ACK with one nit:

+ rc = 0;
+ goto exit;
+ }
+
rc = __virNWFilterInstantiateFilter(conn,
teardownOld,
net->ifname,
@@ -917,6 +924,7 @@ _virNWFilterInstantiateFilter(virConnect
false,
foundNewFilter);

+exit:

Coding conventions document that we prefer 'cleanup:' rather than 'exit:' for the goto statement and label name.

Fixed in and pushed.

   Stefan


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]