[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 3/3] Fix references to self.warning()

On 08/11/2011 06:50 AM, Philipp Hahn wrote:
Only the class CParser declares a method warning(), but the other
classes still try to call their self.warning() method, which fails.

Move the warning() functions to its own base classe and inherit from


that in all other classes.

Signed-off-by: Philipp Hahn<hahn univention de>
  docs/apibuild.py |   48 ++++++++++++++++++++++++++++++------------------
  1 files changed, 30 insertions(+), 18 deletions(-)

First I claim ignorance with xslt, now I'm claiming ignorance with Python :)

However, this one looks easier to review by comparison to the rest of the file, as well as by compilation smoke-tests, which promptly tripped up 'make syntax-check':

docs/apibuild.py-190-        """Stop printing error messages."""
docs/apibuild.py-194-        """Re-start printing error messages."""
maint.mk: found error message ending in period

But those don't seem to be error messages, so much as self-documentation strings. I don't know if the python needs to be tweaked, or if the real problem is that cfg.mk should be exempting .py files from that particular syntax check.

Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]