[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 01/10] linkstate: XML for modification of interface's link state.

On 08/11/2011 09:27 AM, Peter Krempa wrote:
Adds a optional element to XML definition of domains for
modification of link state of network interfaces.
  docs/formatdomain.html.in |   21 +++++++++++++++++++++
  docs/schemas/domain.rng   |   11 +++++++++++
  2 files changed, 32 insertions(+), 0 deletions(-)

diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in
index 7d2ba8a..dc4cecb 100644
--- a/docs/formatdomain.html.in
+++ b/docs/formatdomain.html.in
@@ -1997,6 +1997,27 @@ qemu-kvm -net nic,model=? /dev/null
        <span class="since">Since 0.9.4</span>

+<h5><a name="elementLink">Modyfing virtual link state</a></h5>
+  ...
+&lt;interface type='network'&gt;
+&lt;source network='default'/&gt;
+&lt;target dev='vnet0'/&gt;
+<b>&lt;link state='down'/&gt;</b>
+  ...</pre>
+      This element provides means of setting state of the virtual network link.
+      Possible values for atrribute<code>state</code>  are<code>up</code>  and


+<code>down</code>. If<code>down</code>  is specified as the value, the interface
+      behaves as if it had the network cable disconnected. Default behaviour, if this
+      element is unspecified is to have the link state<code>up</code>.

Mismatch of commas doesn't read well. Both of these approaches will work in English:

Default behavior, if element is unspecified, is ...
Default behavior if element is unspecified is ...

although I tend to prefer the first (that is, add a comma after "unspecified").

ACK with those fixes, although no point in pushing the xml changes until we fix the rest of the series to use the new xml via existing api rather than inventing new special-purpose api.

Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]