[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 02/10] linkstate: Public API for modifying link state on interfaces

On 08/11/2011 09:27 AM, Peter Krempa wrote:
This API adds methods to modify link state of virtual
interfaces of a domain.

Idea of this API is to enable simulation of unplugging
(virtual) cable from the machine to test networks or
to allow propagation of topology changes on the host.
  include/libvirt/libvirt.h.in |   24 ++++++++++++++++++++++++
  src/libvirt_public.syms      |    6 ++++++
  2 files changed, 30 insertions(+), 0 deletions(-)

NACK. I agree with danpb that this is something that already fits quite nicely into virDomainUpdateDevice, without needing specialized API (however, we can still add a specialized virsh command that makes it easier to wrap virDomainUpdateDevice without making the user have to deal with quite as much xml).

Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]