[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 1/4] latency: Introduce new members for _virDomainBlockStats



On Fri, Aug 12, 2011 at 10:17:24PM +0800, Osier Yang wrote:
> The new disk latency related members include:
>     rd_total_times
>     wr_total_times
>     flush_operations
>     flush_total_times
> ---
>  include/libvirt/libvirt.h.in |    4 ++++
>  1 files changed, 4 insertions(+), 0 deletions(-)
> 
> diff --git a/include/libvirt/libvirt.h.in b/include/libvirt/libvirt.h.in
> index b1bda31..cf6bf60 100644
> --- a/include/libvirt/libvirt.h.in
> +++ b/include/libvirt/libvirt.h.in
> @@ -562,8 +562,12 @@ typedef struct _virDomainBlockStats virDomainBlockStatsStruct;
>  struct _virDomainBlockStats {
>    long long rd_req; /* number of read requests */
>    long long rd_bytes; /* number of read bytes */
> +  long long rd_total_times; /* total time spend on cache reads in nano-seconds */
>    long long wr_req; /* number of write requests */
>    long long wr_bytes; /* number of written bytes */
> +  long long wr_total_times; /* total time spend on cache writes in nano-seconds */
> +  long long flush_req; /* number of flushed bytes */
> +  long long flush_total_times; /* total time spend on cache flushes in nano-seconds */
>    long long errs;   /* In Xen this returns the mysterious 'oo_req'. */
>  };

NACK, it is forbidden to modify any structs in the public header
files since that changes the ABI.

Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]