[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 1/6] Add API for duplicating a socket/client file descriptor



On Mon, Aug 15, 2011 at 06:49:58 -0600, Eric Blake wrote:
> On 08/15/2011 03:43 AM, Jiri Denemark wrote:
> > On Mon, Aug 15, 2011 at 09:58:11 +0200, Jiri Denemark wrote:
> >> From: "Daniel P. Berrange"<berrange redhat com>
> >>
> >> * src/rpc/virnetsocket.c, src/rpc/virnetsocket.h: Add
> >>    virNetSocketDupFD()
> >> * src/rpc/virnetclient.c, src/rpc/virnetclient.h: Add
> >>    virNetClientDupFD() and virNetClientGetFD()
> >> ---
> >
> > Ah, I forgot to mention that this patch is in fact a v2 of
> > https://www.redhat.com/archives/libvir-list/2011-July/msg00340.html
> > sent as part of "Add a virtlockd lock manager daemon" series. I modified it
> > according to Eric's suggestions.
> 
> Except you missed one change I had pointed out there: bootstrap.conf 
> needs to list 'fcntl' in the list of gnulib modules (without it, gnulib 
> doesn't guarantee that F_DUPFD_CLOEXEC will work on mingw).

Hmm, I saw fcntl-h in bootstrap.conf, is that something else?

Jirka


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]