[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] Ensure async packets never get marked for sync replies



On Tue, Aug 16, 2011 at 05:49:27PM -0600, Eric Blake wrote:
> On 08/16/2011 05:25 PM, Daniel P. Berrange wrote:
> >From: "Daniel P. Berrange"<berrange redhat com>
> >
> >If a client had initiated a stream abort, it will have a call
> >waiting for a reply in the queue. If more data continues to
> >arrive on the stream, the abort command could mistakenly get
> >signalled as complete. Remove the code from async data processing
> >that looked for waiting calls. Add a sanity check to ensure no
> >async call can ever be marked as needing a reply
> >
> >* src/rpc/virnetclient.c: Ensure async data packets can't
> >   trigger a reply
> >---
> >  src/rpc/virnetclient.c |   12 +++++++-----
> >  1 files changed, 7 insertions(+), 5 deletions(-)
> 
> ACK.

I'll wait for Dave's confirmation that it fixes the probem
he sees before pushing this & the previous patch.

Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]