[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 1/2] build: fix virpidfile on mingw



On 08/17/2011 02:09 PM, Eric Blake wrote:
We already skip the /proc check on non-Linux. So I say we just skip
the kill call on Win32.  This stuff is only an extra sanity check
Nupon loading the pidfile, so I think returning an error is too
mean and we just skip the kill check
Done, and pushing under the build-breaker rule.

  src/util/virpidfile.c |    7 +++++--
  1 files changed, 5 insertions(+), 2 deletions(-)

diff --git a/src/util/virpidfile.c b/src/util/virpidfile.c
index e64b0b3..8206e1a 100644
--- a/src/util/virpidfile.c
+++ b/src/util/virpidfile.c
@@ -200,15 +200,18 @@ int virPidFileReadPathIfAlive(const char *path,
      if (rc<  0)
          return rc;

-    /* Check that it's still alive */
+#ifndef WIN32
+    /* Check that it's still alive.  Safe to skip this sanity check on
+     * mingw, which lacks kill().  */
      if (kill(*pid, 0)<  0) {
virKillProcess (src/util/util.c) handles WIN32 as well.

   Stefan


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]