[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 1/2] build: fix virpidfile on mingw



On 08/17/2011 01:42 PM, Stefan Berger wrote:
- /* Check that it's still alive */
+#ifndef WIN32
+ /* Check that it's still alive. Safe to skip this sanity check on
+ * mingw, which lacks kill(). */
if (kill(*pid, 0)< 0) {
virKillProcess (src/util/util.c) handles WIN32 as well.

Good point - we should probably expand more existing clients of kill() to instead use virKillProcess.

--
Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]