[libvirt] [libvirt-snmp][PATCH 3/3] guestTable: Comparing an array to NULL is not useful

Michal Privoznik mprivozn at redhat.com
Mon Aug 22 12:42:06 UTC 2011


Detected by Coverity
---
 src/libvirtGuestTable_data_get.c |    5 ++---
 1 files changed, 2 insertions(+), 3 deletions(-)

diff --git a/src/libvirtGuestTable_data_get.c b/src/libvirtGuestTable_data_get.c
index cc31e9e..81d8bbf 100644
--- a/src/libvirtGuestTable_data_get.c
+++ b/src/libvirtGuestTable_data_get.c
@@ -83,9 +83,8 @@ libvirtGuestTable_indexes_set_tbl_idx(libvirtGuestTable_mib_index *tbl_idx, char
     /*
      * make sure there is enough space for libvirtGuestUUID data
      */
-    if ((NULL == tbl_idx->libvirtGuestUUID) ||
-        (tbl_idx->libvirtGuestUUID_len <
-         (libvirtGuestUUID_val_ptr_len))) {
+    if (tbl_idx->libvirtGuestUUID_len <
+         (libvirtGuestUUID_val_ptr_len)) {
         snmp_log(LOG_ERR,"not enough space for value\n");
         return MFD_ERROR;
     }
-- 
1.7.3.4




More information about the libvir-list mailing list