[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] qemu: Report error if qemu monitor command not found for BlockJob

On 08/22/2011 07:52 AM, Osier Yang wrote:
* src/qemu/qemu_monitor_json.c: Handle error "CommandNotFound" and
report the error.

* src/qemu/qemu_monitor_text.c: If a sub info command is not found,
it prints the output of "help info", for other commands,
"unknown command" is printed.

Without this patch, libvirt always report:

An error occurred, but the cause is unknown

  src/qemu/qemu_monitor_json.c |   34 ++++++++++++++++++-----------
  src/qemu/qemu_monitor_text.c |   47 +++++++++++++++++++++++++++++++++---------
  2 files changed, 58 insertions(+), 23 deletions(-)

See also Adam's patch approach for the same bug; can we agree on a common patch before pushing anything?

Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]