[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 0/8] Cleanup improper VIR_ERR_NO_SUPPORT use



于 2011年08月23日 17:39, Osier Yang 写道:
Error code VIR_ERR_NO_SUPPORT will be translated to "this function
is not supported by the connection driver", however, it's used
across the whole projects, this patch is trying to cleanup all
the improper use in the source tree.

The modification can be grouped to 3 following groups:

1) The error intends to tell user it's invalid operation.

      s/VIR_ERR_NO_SUPPORT/VIR_ERR_OPERATION_INVALID.

2) The error intends to tell the configuration of domain
    is not supported.

      s/VIR_ERR_NO_SUPPORT/VIR_ERR_CONFIG_UNSUPPORTED/

3) The error intends to tell the function is not implemented
    on some platform.

      * s/VIR_ERR_NO_SUPPORT/VIR_ERR_OPERATION_INVALID/
      * and add error strings

      e.g.

static int
lxcDomainInterfaceStats(virDomainPtr dom,
                         const char *path ATTRIBUTE_UNUSED,
                         struct _virDomainInterfaceStats *stats ATTRIBUTE_UNUSED)
     -lxcError(VIR_ERR_NO_SUPPORT, __FUNCTION__);
     +lxcError(VIR_ERR_OPERATION_INVALID, "%s",
     +         _("interface stats not implemented on this platform"));
     return -1;
}

[PATCH 1/8] conf: Cleanup improper use of VIR_ERR_NO_SUPPORT in
[PATCH 2/8] lxc: Cleanup improper VIR_ERR_NO_SUPPORT use
[PATCH 3/8] nodeinfo: Cleanup improper VIR_ERR_NO_SUPPORT use
[PATCH 4/8] qemu: Cleanup improper VIR_ERR_NO_SUPPORT use
[PATCH 5/8] remote: Cleanup improper VIR_ERR_NO_SUPPORT use
[PATCH 6/8] storage: Cleanup improper VIR_ERR_NO_SUPPORT use
[PATCH 7/8] test: Cleanup improper VIR_ERR_NO_SUPPORT use
[PATCH 8/8] xen: Cleanup improper VIR_ERR_NO_SUPPORT use

Regards
Osier

--
libvir-list mailing list
libvir-list redhat com
https://www.redhat.com/mailman/listinfo/libvir-list
Argh, pushed these series carelessly. Will revert it if there is
something wrong.

Osier


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]