[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [RFC 01/12] Add various USB devices QEMU_CAPS



On Sun, Aug 21, 2011 at 10:01:12PM +0300, Marc-André Lureau wrote:
> ---
>  src/qemu/qemu_capabilities.c |   31 +++++++++++++++++++++++++++++++
>  src/qemu/qemu_capabilities.h |   10 ++++++++++
>  tests/qemuhelptest.c         |   13 ++++++++++---
>  3 files changed, 51 insertions(+), 3 deletions(-)
> 
> diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c
> index f665de4..a33ad4e 100644
> --- a/src/qemu/qemu_capabilities.c
> +++ b/src/qemu/qemu_capabilities.c
> @@ -125,6 +125,17 @@ VIR_ENUM_IMPL(qemuCaps, QEMU_CAPS_LAST,
>                "sga",
>                "virtio-blk-pci.event_idx",
>                "virtio-net-pci.event_idx",
> +
> +              "piix3-usb-uhci", /* 65 */
> +              "piix4-usb-uhci",
> +              "usb-ehci",
> +              "ich9-usb-ehci1",
> +              "ich9-usb-uhci1",
> +
> +              "ich9-usb-uhci2", /* 70 */
> +              "ich9-usb-uhci3",
> +              "vt82c686b-usb-uhci",
> +              "usb-redir",
>      );

IMHO this is a little bit overkill. If bunch of things were introduced
at the same time there is no need to probe for each one of them. ie
you'll never find that you have 'ich9-usb-echi', but not also have
'ich9-usb-uhci1,2,3', so probing for all 4 individually just bloats
our capabilities.

Likewise we don't generally bother probing for things which have been
around since 0.9.0 (our min version) ie the piix USB controllers.

Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]