[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 1/3] pci: Fix callers of pciDeviceListSteal() when there's more than one device

On 08/24/2011 09:30 AM, Shradha Shah wrote:

long subject line; I've shortened it to fit in more typical commit length:

pci: fix pciDeviceListSteal on multiple devices

pciDeviceListSteal(pcidevs, dev) removes dev from pcidevs reducing
the length of pcidevs, so moving onto what was the next dev is wrong.

Instead callers should pop entry 0 repeatedly until pcidevs is empty.

Signed-off-by: Steve Hodgson<shodgson solarflare com>
Signed-off-by: Shradha Shah<sshah solarflare com>
  src/qemu/qemu_hostdev.c |   13 ++++++-------
  1 files changed, 6 insertions(+), 7 deletions(-)

ACK and pushed.

Thanks for the first-time contribution. Shradha, I added you to AUTHORS, given the git authorship; let me know if I also need to add Steve (due to the Signed-off-by contribution), or adjust any spellings.

Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]