[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 7/8] test: Cleanup improper VIR_ERR_NO_SUPPORT use



On Tue, Aug 23, 2011 at 05:39:44PM +0800, Osier Yang wrote:
> ---
>  src/test/test_driver.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/src/test/test_driver.c b/src/test/test_driver.c
> index b3e24b4..3dfe305 100644
> --- a/src/test/test_driver.c
> +++ b/src/test/test_driver.c
> @@ -4082,7 +4082,7 @@ testStorageFindPoolSources(virConnectPtr conn ATTRIBUTE_UNUSED,
>          break;
>  
>      default:
> -        testError(VIR_ERR_NO_SUPPORT,
> +        testError(VIR_ERR_OPERATION_INVALID,
>                    _("pool type '%s' does not support source discovery"), type);
>      }
>  

This patch has caused a virt-install to fail its tests

   http://builder.virt-tools.org/module-virtinst.html

======================================================================
ERROR: testEnumerateiSCSI (tests.storage.TestStorage)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/var/lib/builder/source-root/virtinst/tests/storage.py", line 225, in testEnumerateiSCSI
    host=host)
  File "/var/lib/builder/source-root/virtinst/virtinst/Storage.py", line 328, in pool_list_from_sources
    xml = conn.findStoragePoolSources(pool_type, source_xml, 0)
  File "/var/lib/builder/install-root/lib64/python2.7/site-packages/libvirt.py", line 2030, in findStoragePoolSources
    if ret is None: raise libvirtError ('virConnectFindStoragePoolSources() failed', conn=self)
libvirtError: Requested operation is not valid: pool type 'iscsi' does not support source discovery

The storage drivers have lots of different pool types, so you
may have the driver method implemented, but different pool types
may still return VIR_ERR_NO_SUPPORT, and virt-install is expecting
that here.

I think this change should be reverted

Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]