[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] reserve slot 1 on pci bus0



On 08/30/2011 06:16 PM, Wen Congyang wrote:
At 08/31/2011 06:28 AM, Eric Blake Write:
On 08/23/2011 08:47 PM, Wen Congyang wrote:
After supporting multi function pci device, we only reserve function 1
on slot 1.
The user can use the other function on slot 1 in the xml config file.
We should
detect this wrong usage.

+    for (function = 0; function<= QEMU_PCI_ADDRESS_LAST_FUNCTION;
function++) {

Isn't this an off-by-one?  Compare commit 7ae740fc.

Yes, it should be 'function<  QEMU_PCI_ADDRESS_LAST_FUNCTION'

I've now had a closer look at your patch, and it looks reasonable.

ACK with that change.

--
Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]