[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH libvirt-glib 10/15] Remove used of '@' in makefiles



s/used/use in subject, ACK otherwise

On Thu, Dec 01, 2011 at 02:05:38PM +0000, Daniel P. Berrange wrote:
> From: "Daniel P. Berrange" <berrange redhat com>
> 
> * Makefile.am, python/Makefile.am: Remove use of @FOO@ in favour
>   of $(FOO)
> ---
>  Makefile.am        |    4 ++--
>  python/Makefile.am |    2 +-
>  2 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/Makefile.am b/Makefile.am
> index 2b4ee95..13a7d32 100644
> --- a/Makefile.am
> +++ b/Makefile.am
> @@ -6,9 +6,9 @@ ACLOCAL_AMFLAGS = -I m4
>  pkgconfigdir = $(libdir)/pkgconfig
>  pkgconfig_DATA = libvirt-glib-1.0.pc libvirt-gconfig-1.0.pc libvirt-gobject-1.0.pc
>  
> -EXTRA_DIST = @PACKAGE  spec $(pkgconfig_DATA:%.pc=%.pc.in)
> +EXTRA_DIST = $(PACKAGE).spec $(pkgconfig_DATA:%.pc=%.pc.in)
>  
> -DISTCLEAN_FILES = @PACKAGE  spec $(pkgconfig_DATA)
> +DISTCLEAN_FILES = $(PACKAGE).spec $(pkgconfig_DATA)
>  
>  DISTCHECK_CONFIGURE_FLAGS = --enable-gtk-doc=yes --enable-introspection=yes
>  
> diff --git a/python/Makefile.am b/python/Makefile.am
> index f4f0d9f..c890864 100644
> --- a/python/Makefile.am
> +++ b/python/Makefile.am
> @@ -23,7 +23,7 @@ libvirtglibmod_la_LIBADD = ../libvirt-glib/libvirt-glib-1.0.la
>  
>  install-data-local:
>  	$(mkinstalldirs) $(DESTDIR)$(pythondir)
> -	@INSTALL@ -m 0644 $(srcdir)/libvirtglib.py $(DESTDIR)$(pythondir)
> +	$(INSTALL) -m 0644 $(srcdir)/libvirtglib.py $(DESTDIR)$(pythondir)
>  
>  uninstall-local:
>  	rm -f $(DESTDIR)$(pythondir)/libvirtglib.py
> -- 
> 1.7.6.4
> 
> --
> libvir-list mailing list
> libvir-list redhat com
> https://www.redhat.com/mailman/listinfo/libvir-list

Attachment: pgp5lOWdY4pwH.pgp
Description: PGP signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]