[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH libvirt-glib 01/15] Fix missing backslash in noinst_HEADERS for libvirt-gconfig



On Thu, Dec 01, 2011 at 03:53:05PM +0100, Christophe Fergeau wrote:
> On Thu, Dec 01, 2011 at 02:05:29PM +0000, Daniel P. Berrange wrote:
> > From: "Daniel P. Berrange" <berrange redhat com>
> > 
> > ---
> >  libvirt-gconfig/Makefile.am |    2 +-
> >  1 files changed, 1 insertions(+), 1 deletions(-)
> > 
> > diff --git a/libvirt-gconfig/Makefile.am b/libvirt-gconfig/Makefile.am
> > index ddae5fa..6612445 100644
> > --- a/libvirt-gconfig/Makefile.am
> > +++ b/libvirt-gconfig/Makefile.am
> > @@ -39,7 +39,7 @@ GCONFIG_HEADER_FILES = \
> >  			libvirt-gconfig-storage-vol.h
> >  noinst_HEADERS = \
> >  			libvirt-gconfig-helpers-private.h \
> > -			libvirt-gconfig-object-private.h
> > +			libvirt-gconfig-object-private.h \
> >  			libvirt-gconfig-xml-doc.h
> 
> Oops, ACK
> Btw, do you think libvirt-gconfig-xml-doc.h should be
> libvirt-gconfig-xml-doc-private.h for more consistency ?

Could do, but I don't really mind too much

Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]