[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 2/2] python: Expose binding for virNodeGetMemoryStats()



On 12/02/2011 06:23 PM, Eric Blake wrote:
Copy and paste, so not a problem with this patch any more so than the
other functions that used the same code pattern, but can PyDict_SetItem
fail?  If so, should be be reclaiming the entries added so far before
returning overall failure, instead of silently truncating the return
dictionary by omitting the entries that weren't inserted properly?

ACK with spelling nits fixed.


Thanks. Pushed with spelling fixed, leaving cleanup of unchecked return value of PyDict_SetItem for a later patch.

Peter


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]