[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 2/3] spec: add dmidecode as prereq



On 12/05/2011 10:54 AM, Daniel P. Berrange wrote:
> On Mon, Dec 05, 2011 at 10:38:50AM -0700, Eric Blake wrote:
>> https://bugzilla.redhat.com/show_bug.cgi?id=754909 complains that
>> because libvirt didn't require dmidecode, that the logs are noisy
>> and virConnectGetSysinfo needlessly fails.  Even 'virt-what' requires
>> dmidecode, so it's not that onerous of a dependency.  We may be
>> able to drop this in the future when we move to parsing sysfs data,
>> but for now, listing the dependency will help matters.
>>
>> * libvirt.spec.in (Requires): Sort Requires before BuildRequires.
>> Add dmidecode.
> 
> ACK

Thanks; pushed 2/3 and 3/3.  I'll post a v2 for patch 1/3 in a few minutes.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]