[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] npiv: Auto-generate WWNs if it's not specified



On Tue, Dec 06, 2011 at 06:52:54PM +0800, Osier Yang wrote:
> To not change the old API behavior (if no WWNs is specified, error
> is throwed and the device creation quits), this patch introduce
> an new flag (VIR_NODE_DEVICE_CREATE_XML_GENERATE_WWN), which indicates
> the WWNs will be generated automatically by libvirt if they are not
> specified, and it's ignored if the the WWNs are specified.

IMHO we don't need to add a new flag here. It is perfectly acceptable
if scenarios which used to throw an error, now start working due to
new functionality being implemented.

Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]