[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 1/2] maint: use common xml quoting style



On Mon, Dec 05, 2011 at 02:48:30PM -0700, Eric Blake wrote:
> According to the official XML specification [1], attributes
> can be specified with either ' or " (where the difference is
> that you can use '"' or '"' but must use """,
> and conversely for "'" or "'" vs. ''').  But our
> code generation in src/conf prefers to output the '' notation,
> as it is easier to write C string literals for that style.
> Using a consistent style throughout libvirt will make it
> easier for users to copy-and-paste without wondering why we
> switch quoting styles mid-stream.
> 
> [1] http://www.w3.org/TR/xml11/#NT-Reference
> 
> Mechanical conversion done with:
> 
> $ find -name '*.xml' | \
>    xargs sed -i 's/\([a-zA-Z0-9_]*=\)"\([^"]*\)"/\1'\''\2'\''/g'
> 
> followed by inspecting the results, and touching up the change
> in tests/xml2sexprdata/xml2sexpr-escape.xml to fix 'make check'.

ACK

Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]