[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] Improve error reporting when libvirtd is not installed



On 12/06/2011 02:48 PM, Daniel P. Berrange wrote:
> From: "Daniel P. Berrange" <berrange redhat com>
> 
> Currently if you try to connect to a local libvirtd when
> libvirtd is not in $PATH, you'll get an error
> 
>   error: internal error invalid use of command API
> 
> This is because remoteFindDaemonPath() returns NULL, which
> causes us to pass NULL into virNetSocketConnectUNIX which
> in turn causes us to pass NULL into virCommandNewArgList.
> 
> Adding missing error checks improves this to
> 
>   error: internal error Unable to locate libvirtd daemon in $PATH

Nice.  Seems simple enough to include in 0.9.8.

> +    if (spawnDaemon && !binary) {
> +        virNetError(VIR_ERR_INTERNAL_ERROR,
> +                    _("Auto-spawn of daemon requested, but not binary specified"));

s/not/no/

ACK with spelling nit fixed.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]